2013/10/9 <ville.syrjala@xxxxxxxxxxxxxxx>:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> The fbc_wm_enabled member in intel_wm_config is useless for the time
> being. The original idea for it was that we'd pre-compute it and so
> that the WM merging process could know whether it needs to worry
> about FBC watermarks at all.
If it compiles, then I guess it's fine, right?
>
> But we don't have a convenient way to pre-check for the possibility
> of FBC being used. intel_update_fbc() should be split up for that.
I wonder if we should keep that register bit which says "disable FBC
watermarks" disabled all the time while FBC is disabled... Last time I
checked, we were not doing this.
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx>
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index d307039..e81221d 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -2213,7 +2213,6 @@ struct intel_wm_config {
> unsigned int num_pipes_active;
> bool sprites_enabled;
> bool sprites_scaled;
> - bool fbc_wm_enabled;
> };
>
> /*
> --
> 1.8.1.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Paulo Zanoni
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
