On Thu, Oct 10, 2013 at 08:32:23PM +0300, ville.syrjala@xxxxxxxxxxxxxxx wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > The current pre-gen4 pipe off code might break out of the loop > due to the timeout, but then the fail to print the warning. > > Fix the issue by making sure we pair up the correct time comparison > functions. It would be enough to change just the final check to use > time_after_eq(), but also changing the loop condition to use > time_before() instead of time_after() makes the whole thing look a > bit saner since then we always compare jiffies and timeout in the same > order, and the words before and after now feel more natural when > talking about the timeout. Don't you also want to recheck last_line just in case it managed to finish in the nick of time? -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
