> > On 2/9/2024 2:14 AM, Suraj Kandpal wrote: > > Use xe_device struct instead of drm_i915_private so as to not cause > > confusion and comply with Xe standards even though xe_device gets > > translated to drm_i915_private. > > AFAIU xe_device does not get translated to drm_i915_private, it's really an > xe_device struct under the hood. > The change itself looks ok to me, but I'll leave the final r-b to someone on the > display side to confirm this is the correct approach. > Thanks Daniele for having a look maybe Jani or Ankit can help with the final rb Regards, Suraj Kandpal > Daniele > > > > > Signed-off-by: Suraj Kandpal <suraj.kandpal@xxxxxxxxx> > > --- > > drivers/gpu/drm/xe/display/xe_hdcp_gsc.c | 15 ++++++++------- > > 1 file changed, 8 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c > > b/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c > > index 0f11a39333e2..5d1d0054b578 100644 > > --- a/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c > > +++ b/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c > > @@ -3,30 +3,31 @@ > > * Copyright 2023, Intel Corporation. > > */ > > > > -#include "i915_drv.h" > > +#include <drm/drm_print.h> > > #include "intel_hdcp_gsc.h" > > +#include "xe_device_types.h" > > > > -bool intel_hdcp_gsc_cs_required(struct drm_i915_private *i915) > > +bool intel_hdcp_gsc_cs_required(struct xe_device *xe) > > { > > return true; > > } > > > > -bool intel_hdcp_gsc_check_status(struct drm_i915_private *i915) > > +bool intel_hdcp_gsc_check_status(struct xe_device *xe) > > { > > return false; > > } > > > > -int intel_hdcp_gsc_init(struct drm_i915_private *i915) > > +int intel_hdcp_gsc_init(struct xe_device *xe) > > { > > - drm_info(&i915->drm, "HDCP support not yet implemented\n"); > > + drm_dbg_kms(&xe->drm, "HDCP support not yet implemented\n"); > > return -ENODEV; > > } > > > > -void intel_hdcp_gsc_fini(struct drm_i915_private *i915) > > +void intel_hdcp_gsc_fini(struct xe_device *xe) > > { > > } > > > > -ssize_t intel_hdcp_gsc_msg_send(struct drm_i915_private *i915, u8 > > *msg_in, > > +ssize_t intel_hdcp_gsc_msg_send(struct xe_device *xe, u8 *msg_in, > > size_t msg_in_len, u8 *msg_out, > > size_t msg_out_len) > > {