On Mon, Sep 30, 2013 at 05:23:57PM +0300, ville.syrjala@xxxxxxxxxxxxxxx wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > If the primary gets marked as disabled while the pipe is off for > instance, we should still re-enable it when the pipe is turned on, > unless the sprite covers it fully also in that configuration. > Unfortunately we do the plane visibility checks only in the sprite code, > which is executed after the primary enabling when turning the pipe off. > > Ideally we should compute the plane visibility before touching the > hardware at all, but for now just set the primary_disabld flag > in intel_{enable,disable}_plane. Can I humbly request that we can these functions to intel_enable_primary/intel_disable_primary? In addition to setting the state, it would be nice to assert that the state was still valid before the change. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx