> -----Original Message----- > From: daniel.vetter@xxxxxxxx [mailto:daniel.vetter@xxxxxxxx] On Behalf Of > Daniel Vetter > Sent: Monday, September 23, 2013 4:57 PM > To: Lin, Mengdong > Cc: ville.syrjala@xxxxxxxxxxxxxxx; intel-gfx; Arora, MukeshX > Subject: Re: [PATCH v2] drm/i915/hsw: Add display Audio codec > disable sequence for Haswell > > On Mon, Sep 23, 2013 at 10:52 AM, Lin, Mengdong <mengdong.lin@xxxxxxxxx> > wrote: > >> Also I'd really like to see the audio stuff being tracked in the pipe > >> config instead of splattering these different ad-hoc state bits like > >> intel_crtc->eld_vld all over the place. > >> -Daniel > > > > How about adding a flag "has_audio" to intel_crtc->config? > > If okay, I'll write a patch to clean up checking on intel_crtc->eld_vld here and > there. > > That's actually my plan: HDMI/DP encoders should set config->has_audio in > their ->compute_config if we have audio enabled, and everything else should > then just check intel_crtc->config.has_audio. If you do the patch for hsw I'll > volunteer to convert older platforms. > -Daniel > -- Okay. I'll do the patch for HSW. Thanks Mengdong _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
