On Thu, Sep 19, 2013 at 02:53:58PM +0200, Daniel Vetter wrote:
> I always get royally confused how a modeline with all zeros could
> possible pass the paranoid pipe config checker. Until I realize again
> that we only check the crtc timings. So dump the crtc timings for the
> adjusted mode.
>
> This will be even more important for 3D support where the crtc timings
> are markedly different from the input modeline if we have
> frame-by-frame 3d output enabled.
>
> Cc: Damien Lespiau <damien.lespiau@xxxxxxxxx>
> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
Reviewed-by: Damien Lespiau <damien.lespiau@xxxxxxxxx>
--
Damien
> ---
> drivers/gpu/drm/i915/intel_display.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 1a2569f..d55d041 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -8327,6 +8327,17 @@ compute_baseline_pipe_bpp(struct intel_crtc *crtc,
> return bpp;
> }
>
> +static void intel_dump_crtc_timings(const struct drm_display_mode *mode)
> +{
> + DRM_DEBUG_KMS("crtc timings: %d %d %d %d %d %d %d %d %d, "
> + "type: 0x%x flags: 0x%x\n",
> + mode->clock,
> + mode->crtc_hdisplay, mode->crtc_hsync_start,
> + mode->crtc_hsync_end, mode->crtc_htotal,
> + mode->crtc_vdisplay, mode->crtc_vsync_start,
> + mode->crtc_vsync_end, mode->crtc_vtotal, mode->type, mode->flags);
> +}
> +
> static void intel_dump_pipe_config(struct intel_crtc *crtc,
> struct intel_crtc_config *pipe_config,
> const char *context)
> @@ -8352,6 +8363,7 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,
> drm_mode_debug_printmodeline(&pipe_config->requested_mode);
> DRM_DEBUG_KMS("adjusted mode:\n");
> drm_mode_debug_printmodeline(&pipe_config->adjusted_mode);
> + intel_dump_crtc_timings(&pipe_config->adjusted_mode);
> DRM_DEBUG_KMS("port clock: %d\n", pipe_config->port_clock);
> DRM_DEBUG_KMS("pipe src size: %dx%d\n",
> pipe_config->pipe_src_w, pipe_config->pipe_src_h);
> --
> 1.8.1.4
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
