On Thu, Sep 19, 2013 at 02:06:39PM +0200, Daniel Vetter wrote: > No buffer overflows here, but better safe than sorry. > > v2: > - Fixup the sizeof conversion, I've missed the pointer deref (Jani). > - Drop the redundant GFP_ZERO, kcalloc alreads memsets (Jani). > - Use kmalloc_array for the execbuf fastpath to avoid the memset > (Chris). I've opted to leave all other conversions as-is since they > aren't in a fastpath and dealing with cleared memory instead of > random garbage is just generally nicer. I still don't agree with this change to kmalloc_array. The code is written explicitly such that an invalid buffer_count is reported as EINVAL and not ENOMEM. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
