On Tue, Sep 17, 2013 at 9:11 AM, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote: > Heh, I was reading the subject as relay-out, not re-layout for a while > there. -ENOCOFFEE. Added a dash to the commit message. > On Tue, 17 Sep 2013, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote: >> Especially intel_gmch_panel_fitting was shifting way too much over the >> right edge and also was way too long. So extract two helpers, one for >> gen4+ and one for gen2/3. Now the entire thing is again almost >> readable ... >> >> Spurred by checkpatch freaking out about a Ville's pipeconfig rework >> in intel_panel.c >> >> Otherwise just two lines that needed appropriate breaking. > > I suppose it should be kind of obvious, but I do like the explicit "no > functional changes" in the commit message when none are intended. Me too, but somehow I wanted to add it but then forgotten. Fixed. > With the reduced indent, you could have re-flowed some statements to > fewer lines while at it... but meh. Good stuff. > > Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> Thanks for the review, patch slurped in. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
