Re: [PATCH 4/5] drm/i915: clear opregon->lid_state after we unmap it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I think this is just the right thing to do, so:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>

On Thu, Sep 12, 2013 at 1:58 PM, Paulo Zanoni <przanoni@xxxxxxxxx> wrote:
> From: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx>
>
> We don't seem to be using the pointer after it's unmapped, so this
> patch doesn't fix any bug I can reproduce.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/intel_opregion.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
> index a01e0f8..dd88c08 100644
> --- a/drivers/gpu/drm/i915/intel_opregion.c
> +++ b/drivers/gpu/drm/i915/intel_opregion.c
> @@ -668,6 +668,7 @@ void intel_opregion_fini(struct drm_device *dev)
>         opregion->swsci = NULL;
>         opregion->asle = NULL;
>         opregion->vbt = NULL;
> +       opregion->lid_state = NULL;
>  }
>
>  static void swsci_setup(struct drm_device *dev)
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux