On Tue, Sep 3, 2013 at 10:13 AM, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > On Tue, Sep 03, 2013 at 11:04:30AM +0300, ville.syrjala@xxxxxxxxxxxxxxx wrote: >> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> >> >> First of all we should not be looking at fb->{width,height} as those do >> not tell us what the actual pipe size is. Second of all we need to use >> >= for the comparison. >> >> So fix the comparison, and make use of the new pipe_src_{w,h} to >> determine the real pipe source dimensions. >> >> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Whoops. > > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > And r-b for its sibling as well. I am pretty sure there are real-world > bugs out there, but they are going to pretty be rare and the same user > is never likely to see it twice... And just maybe more recent hw isn't > quite so hang-happy! Hm, can we have an igt for this? We kinda don't any sprite/cursor test at all right now, but we need to start somewhere ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx