On Mon, Sep 02, 2013 at 10:11:43PM +0300, Ville Syrjälä wrote: > On Mon, Sep 02, 2013 at 08:46:19PM +0200, Daniel Vetter wrote: > > On Mon, Sep 02, 2013 at 09:13:38PM +0300, ville.syrjala@xxxxxxxxxxxxxxx wrote: > > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > > > Rather that mess about with hdisplay/vdisplay from requested_mode, add > > > explicit pipe src size information to pipe config. > > > > > > Now requested_mode is only really relevant for dvo/sdvo output timings. > > > For everything else either adjusted_mode or pipe src size should be > > > used. > > > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > Not sold on this - imo it makes more sense to keep track of this in a new > > plane config structure or something similar which ties the fb + metadata > > to the crtc. Then we could move a bunch of things we currently have in the > > pipe config or someplaces else even (fbc, ips, ...) over there. > > This size isn't the plane size. It's the pipe size. Two different things. Oops, I guess I'm confused about this. In that case this makes tons of sense. Now just one of our residential watermarks experts (definitely not me) needs to double-check that we're always using the right thing ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
