Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on 6e5f96153989e454041848f66a5227be9bd0bbc3] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/drm-i915-Move-fbdev-functions/20230328-191627 base: 6e5f96153989e454041848f66a5227be9bd0bbc3 patch link: https://lore.kernel.org/r/20230328111422.23986-5-tzimmermann%40suse.de patch subject: [PATCH 4/4] drm/i915: Implement fbdev emulation as in-kernel client config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20230329/202303290420.6rd5p4br-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/6db03fde4587438371c6f7871675cba6389a1319 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Thomas-Zimmermann/drm-i915-Move-fbdev-functions/20230328-191627 git checkout 6db03fde4587438371c6f7871675cba6389a1319 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 olddefconfig make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/i915/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303290420.6rd5p4br-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): In file included from drivers/gpu/drm/i915/i915_driver.c:55: >> drivers/gpu/drm/i915/display/intel_fbdev.h:22:1: error: expected identifier or '(' before '{' token 22 | { | ^ vim +22 drivers/gpu/drm/i915/display/intel_fbdev.h 6dfccb95cf17cd drivers/gpu/drm/i915/intel_fbdev.h Jani Nikula 2019-04-05 15 6dfccb95cf17cd drivers/gpu/drm/i915/intel_fbdev.h Jani Nikula 2019-04-05 16 #ifdef CONFIG_DRM_FBDEV_EMULATION 6db03fde458743 drivers/gpu/drm/i915/display/intel_fbdev.h Thomas Zimmermann 2023-03-28 17 void intel_fbdev_setup(struct drm_i915_private *dev_priv); 6dfccb95cf17cd drivers/gpu/drm/i915/intel_fbdev.h Jani Nikula 2019-04-05 18 void intel_fbdev_set_suspend(struct drm_device *dev, int state, bool synchronous); c1c04560ac038d drivers/gpu/drm/i915/display/intel_fbdev.h Jani Nikula 2022-02-15 19 struct intel_framebuffer *intel_fbdev_framebuffer(struct intel_fbdev *fbdev); 6dfccb95cf17cd drivers/gpu/drm/i915/intel_fbdev.h Jani Nikula 2019-04-05 20 #else 6db03fde458743 drivers/gpu/drm/i915/display/intel_fbdev.h Thomas Zimmermann 2023-03-28 21 void intel_fbdev_setup(struct drm_i915_private *dev_priv); 6dfccb95cf17cd drivers/gpu/drm/i915/intel_fbdev.h Jani Nikula 2019-04-05 @22 { 6dfccb95cf17cd drivers/gpu/drm/i915/intel_fbdev.h Jani Nikula 2019-04-05 23 } 6dfccb95cf17cd drivers/gpu/drm/i915/intel_fbdev.h Jani Nikula 2019-04-05 24 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
