On Mon, Aug 19, 2013 at 09:31:42PM +0200, Thierry Reding wrote: > On Mon, Aug 19, 2013 at 02:49:50PM +0100, Damien Lespiau wrote: > > On Thu, Aug 15, 2013 at 05:12:00PM +0200, Thierry Reding wrote: > > > On Wed, Aug 14, 2013 at 06:19:12PM +0100, Damien Lespiau wrote: > > > [...] > > > > +#define HDMI_IDENTIFIER 0x000c03 > > > > > > HDMI_IDENTIFIER sounds really generic. Perhaps HDMI_INFOFRAME_OUI_HDMI? > > > > This identifier is not infoframe specific, it's the IEEE OUI: > > > > http://standards.ieee.org/develop/regauth/oui/oui.txt > > > > would HDMI_IEEE_OUI suit you? > > Yes, that sounds much better. Or perhaps IEEE_OUI_HDMI? From a quick > grep through the kernel code using the OUI as a prefix seems to be > slightly more common. If we ever end up adding a header to collect > OUIs it'd be useful to namespace them somehow. Hopefully we can agree that HDMI_IEEE_OUI is fine :) Would you mind having a look at the two patches introduced to address your comments HDMI 4k support v4 http://lists.freedesktop.org/archives/dri-devel/2013-August/043988.html Patches 11 and 14. Thanks, -- Damien _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
