From: Sean Paul <seanpaul@xxxxxxxxxxxx> Lower the RPS thresholds and make them symmetric. This patch increases the rate of change of the GPU clock, allowing it to clock up more quickly, and more importantly, clock down when necessary. The problem this patch solves is that a heavy workload would inflate the clock, and then the clock would stick high when the workload went away because the down threshold was too high. This should improve our thermals and power. BUG=chrome-os-partner:11009 TEST=Tested with the PBS koala video, play it along with a GL demo to get the clock up to 1150MHz. Remove the GL demo workload and ensure the clock goes back down to 350MHz. Change-Id: I9a489ffd4810fb2b3c2544d6165d664899ec0e54 Signed-off-by: Sean Paul <seanpaul@xxxxxxxxxxxx> Reviewed-on: https://gerrit.chromium.org/gerrit/27184 Reviewed-by: Stéphane Marchesin <marcheu@xxxxxxxxxxxx> Reviewed-by: Duncan Laurie <dlaurie@xxxxxxxxxxxx> [marcheu: Fixups for 3.8] Signed-off-by: Stéphane Marchesin <marcheu@xxxxxxxxxxxx> --- drivers/gpu/drm/i915/intel_pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 6d5e3ed..9ff2285 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -2611,8 +2611,8 @@ static void gen6_enable_rps(struct drm_device *dev) dev_priv->rps.max_delay << 24 | dev_priv->rps.min_delay << 16); - I915_WRITE(GEN6_RP_UP_THRESHOLD, 59400); - I915_WRITE(GEN6_RP_DOWN_THRESHOLD, 100000); + I915_WRITE(GEN6_RP_UP_THRESHOLD, 0x4000); + I915_WRITE(GEN6_RP_DOWN_THRESHOLD, 0x4000); I915_WRITE(GEN6_RP_UP_EI, 66000); I915_WRITE(GEN6_RP_DOWN_EI, 350000); -- 1.8.3.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
