On Wed, 01 Feb 2023, Mavroudis Chatzilaridis <mavchatz@xxxxxxxxxxxxxx> wrote: > This laptop uses inverted backlight PWM. Thus, without this quirk, > backlight brightness decreases as the brightness value increases and > vice versa. > > Signed-off-by: Mavroudis Chatzilaridis <mavchatz@xxxxxxxxxxxxxx> Thanks for the patch, but this really needs a bug filed at fdo gitlab with dmesg, VBT, etc. [1] I don't doubt you, but the fix may need to be different. All the previous quirks were on ancient GM45, and I was pretty sure the problems were limited to that platform. I'm hesitant to add the quirk to other platforms without more info. Thanks, Jani. [1] https://gitlab.freedesktop.org/drm/intel/wikis/How-to-file-i915-bugs > --- > drivers/gpu/drm/i915/display/intel_quirks.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c b/drivers/gpu/drm/i915/display/intel_quirks.c > index 6e48d3bcdfec..a280448df771 100644 > --- a/drivers/gpu/drm/i915/display/intel_quirks.c > +++ b/drivers/gpu/drm/i915/display/intel_quirks.c > @@ -199,6 +199,8 @@ static struct intel_quirk intel_quirks[] = { > /* ECS Liva Q2 */ > { 0x3185, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time }, > { 0x3184, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time }, > + /* HP Notebook - 14-r206nv */ > + { 0x0f31, 0x103c, 0x220f, quirk_invert_brightness }, > }; > > void intel_init_quirks(struct drm_i915_private *i915) > -- > 2.34.1 > > -- Jani Nikula, Intel Open Source Graphics Center
