On Mon, Aug 12, 2013 at 10:15:06AM +0100, Chris Wilson wrote:
> On Mon, Aug 12, 2013 at 11:09:56AM +0200, Daniel Vetter wrote:
> > Doesn't do more than an if (drmtest_run_test(name)) right now, but
> > as soon as we get a bit of infrastructure to handle test failures and
> > skipping, this will get more interesting.
>
> Just use drm_subtest("name") { }
>
> drm_subtest_block() reads like a function and so one expects "block" to
> be a verb.
The intention was to make clear that the macro expects a C code block
afterwards. See the later patches for some of the fun I add ... I see that
the _block suffix can be misread, but tbh I don't have any other ideas
that might properly convey what this thing is. The 2nd best I could think
of is do_subtest("name") similar to do {} while (). But that's not great
either.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
