Re: [PATCH 2/2] drm/i915: drop unnecessary local variable to suppress build warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Aug 11, 2013 at 12:44:02PM +0300, Jani Nikula wrote:
> Although I could not reproduce this (different compiler version,
> perhaps), reportedly we get:
> 
> drivers/gpu/drm/i915/i915_irq.c:1943:27: warning: ‘score’ may be used
> uninitialized in this function [-Wuninitialized]
> 
> Drop the 'score' variable altogether as it's not really needed.

Right, it was only there because I thought the switch was more readable
with the temporary.
 
> Reported-by: Kees Cook <keescook@xxxxxxxxxxxx>
Go fix your compiler!

> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
Both patches
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux