On Tue, 17 Jan 2023, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> wrote: > On Mon, Jan 16, 2023 at 06:46:44PM +0200, Jani Nikula wrote: >> Move a handful of key enums to a new file intel_display_limits.h. These >> are the enum types, and the MAX/NUM enumerations within them, that are >> used in other headers. Otherwise, there's no common theme between them. >> >> Replace intel_display.h include with intel_display_limit.h where >> relevant, and add the intel_display.h include directly in the .c files >> where needed. >> >> Since intel_display.h is used almost everywhere in display/, include it >> from intel_display_types.h to avoid massive changes across the >> board. There are very few files that would need intel_display_types.h >> but not intel_display.h so this is neglible, and further cleanup between >> these headers can be left for the future. >> >> Overall this change drops the direct and indirect dependencies on >> intel_display.h from about 300 to about 100 compilation units, because >> we can drop the include from i915_drv.h. >> >> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> Thanks! I'd still like to get Ville's ack on this. BR, Jani. > >> >> --- >> >> N.b. intel_display_limits.h is not a great name. I was hoping it was >> only needed for the MAX/NUM enumerations such as I915_MAX_PIPES but >> there are a number of headers that use the types for struct members as >> well. intel_display_enums.h sounds too generic too. Suggestions? >> --- -- Jani Nikula, Intel Open Source Graphics Center
