2013/8/9 Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>: > Quick note... > > On Fri, Aug 09, 2013 at 05:10:05PM -0300, Paulo Zanoni wrote: >> + WARN_ON(!mutex_is_locked(&dev_priv->pc8.lock)); > > Preferred form is now lockdep_assert_held(&dev_priv->pc8.lock); Should I also convert all our other usages of WARN_ON(!mutex_is_locked()) and BUG_ON(!mutex_is_locked()) too? On a separate patch, of course. We have currently no usage of lockdep_assert_held, and I like consistency, so fully switching to the preferred form is good IMHO. > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre -- Paulo Zanoni _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx