On Tue, Aug 6, 2013 at 7:49 PM, Damien Lespiau <damien.lespiau@xxxxxxxxx> wrote: > On Mon, Aug 05, 2013 at 08:50:45PM +0300, Ville Syrjälä wrote: >> On Fri, Aug 02, 2013 at 06:22:58PM +0100, Damien Lespiau wrote: >> > set_frame() wraps the write_frame() vfunc. Be consistent and name the >> > wrapping function like the vfunc being called. >> > >> > It's doubly confusing as we also have a set_infoframes() vfunc and >> > set_infoframe() doesn't wrap it. >> >> I guess the logic was >> set_infoframes -> set_<type>_infoframe -> set_infoframe -> write_infoframe >> >> But I don't really have an opinion on which is better, so: > > Meh, doesn't really matter :) I'll just drop this patch. I think it makes sense and more clearly distinguishes set_infoframes from from writing them. So would have merged ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
