On Tue, Jul 30, 2013 at 07:04:37PM +0100, Chris Wilson wrote: > The PTE layouts are the same for both ppgtt and gtt, so we can simplify > the setup for ppgtt by copying the encoding function pointer from gtt. > This prevents bugs where we update one function pointer, but forget the > other. > > For instance, > > commit 4d15c145a6234d999c0452eec0d275c1fbf0688c > Author: Ben Widawsky <ben@xxxxxxxxxxxx> > Date: Thu Jul 4 11:02:06 2013 -0700 > > drm/i915: Use eLLC/LLC by default when available > > only extends the gtt to use eLLC/LLC cacheing and forgets to also update > the ppgtt function pointer. > > v2: Actually mention the bug being fixed (Kenneth) > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Ben Widawsky <ben@xxxxxxxxxxxx> > Reviewed-by: Kenneth Graunke <kenneth@xxxxxxxxxxxxx> My bad. I've merged this to my temporary tree for when Daniel returns. -- Ben Widawsky, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
