On Fri, Jul 26, 2013 at 7:11 PM, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: >> The problem here is that Jesse was lazy and grabs the lock in >> vlv_crtc_enable, so I think your code here will deadlock. But I agree >> that grabbing the lock where we actually frob the sideband is what we >> want ... > > Looks like vlv_crtc_enable() is the only place that takes the lock around > callbacks, so I propose dropping the locking in that function (and > scoping it around the sideband sequences as above). Yeah, I think moving the locking into callbacks/lower-level functions is the right approach. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
