On Fri, Jul 12, 2013 at 10:56:55AM -0700, Ben Widawsky wrote: > On Fri, Jul 12, 2013 at 06:08:22PM +0100, Chris Wilson wrote: > > Currently, the register access code is split between i915_drv.c and > > intel_pm.c. It only bares a superficial resemblance to the reset of the > > powermanagement code, so move it all into its own file. This is to ease > > further patches to enforce serialised register access. > > > > v2: Scan for random abuse of I915_WRITE_NOTRACE > > v3: Take the opportunity to rename the GT functions as uncore. Uncore is > > the term used by the hardware design (and bspec) for all functions > > outside of the GPU (and CPU) cores in what is also known as the System > > Agent. > > Bikesheds: And I thought you were going to suggest an improved description to try and explain how GT evolved into System Agent into uncore. > Would have preferred the gt/pm_init split as a separate patch. To do that I would either had to export a function to only then unexport it again immediately, or move everything into intel_pm.c and then out again. Neither't seem appealing. > intel_uncore_clear_errors/chec_errors seems silly to me. Agreed, but I was keeping the current code intact... -Chris -- Chris Wilson, Intel Open Source Technology Centre
