On Mon, 09 May 2022 14:01:46 -0700, Alan Previn wrote: > > When GuC-Error-Capture was introduced, we created > buf_in_use as a way to identify if relay logging > had started. It is meant to replace the previous > method where a mmap of the GuC log buffer was Let's change mmap to something else since mmap refers to something different. > the indicator but not since GuC Error Capture > shares that mapping throughout operation. > > However, that method of checking was not updated > when the debugfs guc_log_relay_ctl_open was called. OK guc_log_relay_ctl_open introduced in this series... The code change itself lgtm, though in general I prefer count's to bool's. After tweaking the commit message above this is: Reviewed-by: Ashutosh Dixit <ashutosh.dixit@xxxxxxxxx> > Fix that check. > > Fixes: > drm/i915/guc: Add capture region into intel_guc_log > (daff407a083d). > > Signed-off-by: Alan Previn <alan.previn.teres.alexis@xxxxxxxxx> > Link: https://patchwork.freedesktop.org/patch/479021/?series=101603&rev=1 > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c > index 78d2989fe917..09f4d5fbca82 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c > @@ -568,7 +568,7 @@ int intel_guc_log_set_level(struct intel_guc_log *log, u32 level) > > bool intel_guc_log_relay_created(const struct intel_guc_log *log) > { > - return log->buf_addr; > + return log->relay.buf_in_use; > } > > int intel_guc_log_relay_open(struct intel_guc_log *log) > -- > 2.25.1 >
