On 14.05.22 17:55, Demi Marie Obenour wrote:
In https://github.com/QubesOS/qubes-issues/issues/7481, a user reported that Xorg locked up when resizing a VM window. While I do not have the same hardware the user does and thus cannot reproduce the bug, the stack trace seems to indicate a deadlock between xen_gntdev and i915. It appears that gnttab_unmap_refs_sync() is waiting for i915 to free the pages, while i915 is waiting for the MMU notifier that called gnttab_unmap_refs_sync() to return. Result: deadlock. The problem appears to be that a mapped grant in PV mode will stay in the “invalidating” state until it is freed. While MMU notifiers are allowed to sleep, it appears that they cannot wait for the page to be freed, as is happening here. That said, I am not very familiar with this code, so my diagnosis might be incorrect.
All I can say for now is that your patch seems to be introducing a use after free issue, as the parameters of the delayed work might get freed now before the delayed work is being executed. I don't know why this is happening only with rather recent kernels, as the last gntdev changes in this area have been made in kernel 4.13. I'd suggest to look at i915, as quite some work has happened in the code visible in your stack backtraces rather recently. Maybe it would be possible to free the pages in i915 before calling the MMU notifier? Adding the i915 maintainers. Juergen
Attachment:
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
