On Thu, Jul 4, 2013 at 12:53 PM, Chris Wilson <chris at chris-wilson.co.uk> wrote: > Sanity check that the memory region found through the Graphics Base > of Stolen Memory is reserved and hidden from the rest of the system > through the use of the resource API. > > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch> Two little things: - I think we should give this special resource block a proper name (since it's rather elusive to the system), e.g. rename_region(r, "Graphics Stolen Memory"); - This looks like a nice opportunity to start using the devres stuff to bring some sanity to our teardown/cleanup code. It can only really handle things which can be release exactly in reverse order than they've been acquire. So it won't cover things with tricky ordering constraints, but it should be a start. I.e. s/request_mem_region/devm_request_mem_region/ and then drop the cleanup code. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
