On Wed, Jul 03, 2013 at 09:43:32AM +0100, Chris Wilson wrote: > On Wed, Jul 03, 2013 at 10:07:57AM +0200, Daniel Vetter wrote: > > Otherwise we can't resurrect the bsd ring on gm45 completely. I've > > discovered this trick because module reload recovered the bsd ring, > > making it clear that it's not an issue with the hw or our reset code. > > > > While touching the code update the comment to be a bit clearer about > > what we actually want to reinitialize and which pieces we better leave > > untouched. > > > > Note: In my opinion this is not a stable candidate - historically such > > seemingly correct looking changes in the reset code have lead to big > > heaps of scary hilarity. > > At the expense of leaking all allocated state from earlier. The magic > ingredient here I guess is the resetting of the HWS. Meh, I've tried to forget how broken our init sequence is. I still think sharing the code is probably the right thing instead of adding a bunch of magic calls. I'll have a look how we could fix this best. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
