On Fri, Jun 28, 2013 at 05:24:50PM +0300, Ville Syrj?l? wrote: > On Fri, Jun 28, 2013 at 07:45:31PM +0530, Vijay Purushothaman wrote: > > Since the sprite planes are using synchronized MMIO based flip, no need > > to wait for vblank. Removing this wait allows us to get a nice > > performance boost to both 3D & media workloads based on sprite (~60 fps > > from ~20 fps) > > Nak. We can't unpin the buffer until the hardware has finished reading > from it. > > The proper fix is to do the unpin asynchronously after the flip has > completed. That's one part of the bigger atomic pageflip story. The interested reader is invited to review the patches to do async unpinning here and in set-base sent many, many moons ago. -Chris -- Chris Wilson, Intel Open Source Technology Centre