On Mon, Jun 24, 2013 at 04:22:01PM +0100, Damien Lespiau wrote: > This function has no user outside of intel_pm.c. > > Signed-off-by: Damien Lespiau <damien.lespiau at intel.com> Queued for -next, thanks for the patch. On the topic of stuff that sparse can catch, we've accumulated a few other ones. On a quick look I think the other non-static functions without declaration and the few enum transcoder vs. enum pipe mismatche seem to be worth fixing. Volunteered? -Daniel > --- > drivers/gpu/drm/i915/intel_drv.h | 1 - > drivers/gpu/drm/i915/intel_pm.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h > index ffe9d35..a165be6 100644 > --- a/drivers/gpu/drm/i915/intel_drv.h > +++ b/drivers/gpu/drm/i915/intel_drv.h > @@ -779,7 +779,6 @@ extern int intel_sprite_get_colorkey(struct drm_device *dev, void *data, > extern void intel_init_pm(struct drm_device *dev); > /* FBC */ > extern bool intel_fbc_enabled(struct drm_device *dev); > -extern void intel_enable_fbc(struct drm_crtc *crtc, unsigned long interval); > extern void intel_update_fbc(struct drm_device *dev); > /* IPS */ > extern void intel_gpu_ips_init(struct drm_i915_private *dev_priv); > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index b27bda0..a8483f5 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -368,7 +368,7 @@ static void intel_cancel_fbc_work(struct drm_i915_private *dev_priv) > dev_priv->fbc_work = NULL; > } > > -void intel_enable_fbc(struct drm_crtc *crtc, unsigned long interval) > +static void intel_enable_fbc(struct drm_crtc *crtc, unsigned long interval) > { > struct intel_fbc_work *work; > struct drm_device *dev = crtc->dev; > -- > 1.8.1.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch