[PATCH 4/4] drm: Constify the pretty-print functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 19, 2013 at 10:53 AM, Laurent Pinchart
<laurent.pinchart at ideasonboard.com> wrote:
> Hi Ville,
>
> On Friday 07 June 2013 18:43:07 ville.syrjala at linux.intel.com wrote:
>> From: Ville Syrj?l? <ville.syrjala at linux.intel.com>
>>
>> The structures and strings involved with various pretty-print functions
>> aren't meant to be modified, so make them all const. The exception is
>> drm_connector_enum_list which does get modified in drm_connector_init().
>>
>> While at it move the drm_get_connector_status_name() prototype from
>> drmP.h to drm_crtc.h where it belongs.
>
> This breaks compilation on drm-next:
>
> drivers/gpu/drm/drm_fb_helper.c: In function
> ?drm_fb_helper_parse_command_line?:
> drivers/gpu/drm/drm_fb_helper.c:127:3: warning: passing argument 1 of
> ?fb_get_options? discards ?const? qualifier from pointer target type [enabled
> by default]
> In file included from drivers/gpu/drm/drm_fb_helper.c:35:0:
> include/linux/fb.h:627:12: note: expected ?char *? but argument is of type
> ?const char

The fix is in the fbdev tree, which appears not to be in -next, fail.

Dave.


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux