On Thu, Jun 13, 2013 at 10:26 PM, Imre Deak <imre.deak at intel.com> wrote: >> + if (HAS_PCH_SPLIT(dev)) { >> + assert_fdi_rx_pll_disabled(dev_priv, pipe); >> + assert_shared_dpll_disabled(dev_priv, >> + intel_crtc_to_shared_dpll(crtc)); > > I think if we pick a shared PLL that is currently used by another port > this will trigger. Should the PLL selection be limited to non-shared > PLLs for LVDS? LVDS has a special clock selection setting and there's only eve one LVDS port on any given machine. Which means we won't ever be able to share the dpll with anything else. I'll add this to the commit message when I resend the patch to fix up the debug output. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch