On Thu, Jun 13, 2013 at 10:00:18AM +0100, Chris Wilson wrote: > On Thu, Jun 13, 2013 at 12:54:57AM +0200, Daniel Vetter wrote: > > Dragging random garbage along from the BIOS isn't a good idea, since > > we really only support exactly what we've set up. > > And hopefully we will get failures in the BIOS -> KMS transition making > it much clearer what was missed. Rather than some random modeset in the > future where we switch pipes or outputs or configuration or the weather > changes. > > There were some bits that we don't set in pipeconf (mostly for frame > offset and other esoteric features) that look like they might be used > one day, but as above, we already have problems if they are needed. > > For the series, > Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk> Thanks for the review, all merged to dinq. > However, I don't think I would be so bold as to tag this for stable. Well I wouldn't still be maintainer without the occasional mad case of stupid^Wbold ;-) But since I've decided to push the bugfix through -next we should have plenty of warning time in case it has a bad effect somewhere. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch