On Wed, Jun 12, 2013 at 12:35:33PM +0300, Mika Kuoppala wrote: > After hang check timer has declared gpu to be hang, s/hang/hung/ :-p > rings are reset. In ring reset, when clearing > request list, do post mortem analysis to find out > the guilty batch buffer. > > Select requests for further analysis by inspecting > the completed sequence number which has been updated > into the HWS page. If request was completed, it can't > be related to the hang. > > For noncompleted requests mark the batch as guilty > if the ring was not waiting and the ring head was > stuck inside the buffer object or in the flush region > right after the batch. For everything else, mark > them as innocents. > > v2: Fixed a typo in commit message (Ville Syrj?l?) > > Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com> > --- > +static bool i915_head_inside_request(u32 acthd, u32 rs, u32 re) > +{ Be kind to your reader and use request_start, request_end or just start, end. -Chris -- Chris Wilson, Intel Open Source Technology Centre