A cover letter with the changelog, the base and maybe a pointer to a git tree would be nice. > +static int handle_mmio_cb(struct intel_gvt_mmio_table_iter *iter, u32 offset, > + u32 device, u32 size) > +{ > + if (size < 1024 || offset == i915_mmio_reg_offset(GEN9_GFX_MOCS(0))) > + return handle_mmio(iter, offset, device, size); > + else > + return handle_mmio_block(iter, offset, device, size); > +} No need for an else statement after a return statement. > +/* XXX FIXME i915 has changed PP_XXX definition */ Btw, can someone explain this comment? I has always puzzled me.