== Series Details == Series: drm/i915/fbc: More multi-FBC refactoring (rev3) URL : https://patchwork.freedesktop.org/series/97821/ State : warning == Summary == $ dim checkpatch origin/drm-tip 88faeb3cb9ee drm/i915/fbc: Parametrize FBC register offsets ca4050953f1b drm/i915/fbc: Loop through FBC instances in various places -:42: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__fbc_id' - possible side-effects? #42: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:52: +#define for_each_fbc_id(__fbc_id) \ + for ((__fbc_id) = INTEL_FBC_A; (__fbc_id) < I915_MAX_FBCS; (__fbc_id)++) -:45: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #45: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:55: +#define for_each_intel_fbc(__dev_priv, __fbc, __fbc_id) \ + for_each_fbc_id(__fbc_id) \ + for_each_if((__fbc) = (__dev_priv)->fbc[(__fbc_id)]) -:45: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__fbc_id' - possible side-effects? #45: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:55: +#define for_each_intel_fbc(__dev_priv, __fbc, __fbc_id) \ + for_each_fbc_id(__fbc_id) \ + for_each_if((__fbc) = (__dev_priv)->fbc[(__fbc_id)]) -:115: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #115: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:1344: + +} total: 1 errors, 0 warnings, 3 checks, 253 lines checked 0bcf7d617272 drm/i915/fbc: Introduce device info fbc_mask -:33: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__fbc_id' - possible side-effects? #33: FILE: drivers/gpu/drm/i915/display/intel_fbc.c:52: +#define for_each_fbc_id(__dev_priv, __fbc_id) \ + for ((__fbc_id) = INTEL_FBC_A; (__fbc_id) < I915_MAX_FBCS; (__fbc_id)++) \ + for_each_if(INTEL_INFO(__dev_priv)->display.fbc_mask & BIT(__fbc_id)) total: 0 errors, 0 warnings, 1 checks, 227 lines checked 5ef4aae1e202 drm/i915/fbc: Register per-crtc debugfs files