On Thu, 21 Oct 2021, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > On Thu, Oct 21, 2021 at 01:35:12PM +0300, Jani Nikula wrote: >> On Thu, 21 Oct 2021, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: >> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c >> > index 79a7552af7b5..1375d963c0a8 100644 >> > --- a/drivers/gpu/drm/i915/display/intel_display.c >> > +++ b/drivers/gpu/drm/i915/display/intel_display.c >> > @@ -8818,6 +8818,8 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state) >> > intel_set_cdclk_post_plane_update(state); >> > } >> > >> > + intel_wait_for_vblank_works(state); >> >> Nitpick, I think the function name can be confusing due to the plural >> vs. verb here. intel_wait_for_vblank_work_end(), _finish(), _done()? > > I guess _end() would match what I called the tracepoint. Another > idea could be s/works/workers/ Either works for me. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center
