On Wed, May 8, 2013 at 6:49 PM, Ben Widawsky <ben at bwidawsk.net> wrote: >> I've written this code, so I know what the magic 512 is all about. But >> since Jesse is already confused about them I don't like removing the >> #define that much. Heck, we even tend to use PAGE_SIZE instead of 4096. >> >> What about a GEN6_ prefix instead? Or if you want to make this dynamic >> (iirc we can allocated PDEs in groups of 32) call it _MAX or so? >> >> I like the PT entries part though. >> -Daniel > > If I just bring back #define I915_PPGTT_PD_ENTRIES 512, does this make > you sufficient happy to accept the patch? Yeah, maybe call it GEN6_ instead of I915_ while at it ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
