I've pushed a branch with everything I got from Damien's review so far. http://cgit.freedesktop.org/~bwidawsk/drm-intel/log/?h=vecs-rebase Since it appears Damien hasn't finished yet, I won't send the updated patches in case someone else comes along with more comments on those patches. Also, since Damien found a pretty significant functional bug with the semaphore registers, it would be good if we could get some more testing on the branch. Jocelyn, would it be possible to have someone from your team run a test with libva. If I recall correctly, Haihao found the same bug previously, but we seemed to have missed it this time around when I rebased on the wrong branch. [snip] -- Ben Widawsky, Intel Open Source Technology Center