On Tue, May 07, 2013 at 10:46:01AM -0300, Paulo Zanoni wrote: > 2013/5/7 Damien Lespiau <damien.lespiau at intel.com>: > > On Tue, May 07, 2013 at 02:10:05PM +0100, Damien Lespiau wrote: > >> On Wed, Apr 17, 2013 at 06:15:49PM -0300, Paulo Zanoni wrote: > >> > From: Paulo Zanoni <paulo.r.zanoni at intel.com> > >> > > >> > This should prevent mode set failures on LPT. > >> > > >> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com> > >> > --- > >> > drivers/gpu/drm/i915/intel_pm.c | 5 +++++ > >> > 1 file changed, 5 insertions(+) > >> > > >> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > >> > index 413877d..15ff0ac 100644 > >> > --- a/drivers/gpu/drm/i915/intel_pm.c > >> > +++ b/drivers/gpu/drm/i915/intel_pm.c > >> > @@ -3758,6 +3758,11 @@ static void lpt_init_clock_gating(struct drm_device *dev) > >> > I915_WRITE(SOUTH_DSPCLK_GATE_D, > >> > I915_READ(SOUTH_DSPCLK_GATE_D) | > >> > PCH_LP_PARTITION_LEVEL_DISABLE); > >> > + > >> > + /* WADPOClockGatingDisable */ > >> > + I915_WRITE(_TRANSA_CHICKEN1, > >> > + I915_READ(_TRANSA_CHICKEN1) | > >> > + TRANS_CHICKEN1_DP0UNIT_GC_DISABLE); > >> > >> Don't you need to do that for each pipe? (like the cpt_ version does)? > > It's once per PCH transcoder, but there's just one PCH transcoder on > LPT, so we do it once. Of course, I was looking at the wrong doc. > > > > > Also it's DP0 (zero), not DPO. > > Our documentation is a little inconsistent regarding this, but I guess > the correct name probably has the letter O instead of Zero. The > description inside the LPT TRANS_CHICKEN1 register uses > WADPOClockGatingDisable and the register bit is called "dpounit Gating > Disable". The "BUN" email I got consistently says DPO instead of DP0. > On the CPT/PPT documentation you'll see WADP0ClockGatingDisable but > even the register bit is called "dpounit" and not "dp0unit". So the > only place where I see Zero is on the WA name written inside the CPT > documentation, all the other places use the letter O. Conviced (but then we should rename the cpt_ comment for consistency) Reviewed-by: Damien Lespiau <damien.lespiau at intel.com> -- Damien
