On Fri, May 03, 2013 at 03:03:37PM +0300, Jani Nikula wrote: > On Fri, 03 May 2013, Daniel Vetter <daniel at ffwll.ch> wrote: > > On Fri, May 03, 2013 at 11:17:42AM +0200, dl9pf at gmx.de wrote: > >> From: Jan-Simon M?ller <dl9pf at gmx.de> > >> > >> Description: > >> intel_gmbus_is_forced_bit is no extern as its body is right below. > >> Likewise for intel_gmbus_is_port_valid. > >> > >> This fixes a compilation issue with clang. An initial version of this patch > >> was developed by PaX Team <pageexec at freemail.hu>. > >> This is respin of this patch. > >> > >> Signed-off-by: Jan-Simon M?ller <dl9pf at gmx.de> > >> CC: pageexec at freemail.hu > >> CC: daniel.vetter at ffwll.ch > >> CC: airlied at linux.ie > >> CC: intel-gfx at lists.freedesktop.org > >> CC: dri-devel at lists.freedesktop.org > >> CC: linux-kernel at vger.kernel.org > > Picked up for -fixes, thanks for the patch. > > Please drop it. > > The patch removes the inline keyword, creating dozens of copies of the > functions, and consequently loads of warnings: > > drivers/gpu/drm/i915/i915_drv.h:1803:13: warning: ?intel_gmbus_is_port_valid? defined but not used [-Wunused-function] > drivers/gpu/drm/i915/i915_drv.h:1812:13: warning: ?intel_gmbus_is_forced_bit? defined but not used [-Wunused-function] Meh, rather embarrassing patch reading fail here. Dropped. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
