Daniel Vetter <daniel at ffwll.ch> writes: > On Wed, Apr 24, 2013 at 08:29:21AM -0700, Jesse Barnes wrote: >> On Wed, 24 Apr 2013 18:05:54 +0300 >> Mika Kuoppala <mika.kuoppala at linux.intel.com> wrote: >> >> > This is different than it was in lvds_compute_config. If we get called >> > with DRM_MODE_SCALE_NONE we go to fullscreen instead. >> > Is this intentional? >> >> Yeah, figured I'd make it identical to the eDP case. But we could >> change that one instead if you have a preference. > > SCALE_NONE is rejected in both lvds and edp output's set_property. So not > relevant. Maybe we should smash a WARN into the default case instead? I missed the SCALE_NONE. drm seems to do checking that no values outside the enum set gets through but warn wouldn't hurt. with or without warning added: Reviewed-by: Mika Kuoppala <mika.kuoppala at intel.com> > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch
