PCI revision IDs don't always map to GT and display IP steppings in an
intuitive/sensible way. On many of our recent platforms we've switched
to using revid->stepping lookup tables with the infrastructure in
intel_step.c to handle stepping lookups and comparisons. This series
converts several of our older platforms over to the same table-based
scheme; this is good not only for consistency, but also because some
upcoming DMC work will rely on table-based lookups. Going forward the
only place that revision ID's should really get used directly is when
checking to see if we're running on pre-production hardware.
Note: I haven't added the stepping tables for CFL and its derivatives
(WHL, AML) yet since there are so many different variants and the
steppings work a bit strangely on some of them. We don't have any
stepping-specific workarounds on these platforms, so the tables aren't
necessary until Anusha's DMC work arrives; I'll let her determine the
best way to handle the tables for those. Ditto for CML.
Let's also take the opportunity to drop a bit of effectively dead code
in the workarounds file too.
v2:
- Include an already-reviewed patch from Anusha's DMC series as the
first patch here that changes the naming of the revision ID tables,
and then adjust the naming of the new tables I add here to follow the
same convention.
- Drop the pre-production revisions for all gen11 and earlier
platforms; we're past the point where we usually drop the
pre-production support. intel_detect_preproduction_hw() is updated
with the proper revids for ICL to ensure we print an error and taint
the kernel if the kernel is loaded on a pre-production platform.
- ICL workarounds that only apply to pre-production steppings are
dropped.
- For platforms where GT stepping is always the same as display
stepping, we use a macro to assign them both at once to make it more
obvious how the platform works.
- Stepping tables for BXT and GLK are added. They're completely unused
in our current code (we have no stepping-specific workarounds), but
some DMC patches from Anusha will arrive shortly that require these.
Note that the BXT revision macros we had previously were completely
wrong; it's a good thing they weren't actually being used for
anything.
v3:
- Use COMMON_STEP() macro on a few more platforms. (Anusha)
v4:
- s/COMMON_STEPPING/COMMON_STEP/ across whole series. (Lucas)
Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
Cc: Anusha Srivatsa <anusha.srivatsa@xxxxxxxxx>
Cc: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
Anusha Srivatsa (1):
drm/i915/step: s/<platform>_revid_tbl/<platform>_revids
Matt Roper (11):
drm/i915: Make pre-production detection use direct revid comparison
drm/i915/skl: Use revid->stepping tables
drm/i915/kbl: Drop pre-production revision from stepping table
drm/i915/bxt: Use revid->stepping tables
drm/i915/glk: Use revid->stepping tables
drm/i915/icl: Use revid->stepping tables
drm/i915/jsl_ehl: Use revid->stepping tables
drm/i915/rkl: Use revid->stepping tables
drm/i915/dg1: Use revid->stepping tables
drm/i915/cnl: Drop all workarounds
drm/i915/icl: Drop workarounds that only apply to pre-production
steppings
.../drm/i915/display/intel_display_power.c | 2 +-
drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +-
drivers/gpu/drm/i915/display/intel_psr.c | 4 +-
drivers/gpu/drm/i915/gt/intel_region_lmem.c | 2 +-
drivers/gpu/drm/i915/gt/intel_workarounds.c | 108 ++----------------
drivers/gpu/drm/i915/i915_drv.c | 9 +-
drivers/gpu/drm/i915/i915_drv.h | 79 ++-----------
drivers/gpu/drm/i915/intel_pm.c | 2 +-
drivers/gpu/drm/i915/intel_step.c | 104 ++++++++++++++---
drivers/gpu/drm/i915/intel_step.h | 4 +
10 files changed, 119 insertions(+), 197 deletions(-)
--
2.25.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
