On Tue, Apr 23, 2013 at 04:56:09PM +0200, Daniel Vetter wrote: > On Tue, Apr 23, 2013 at 05:27:08PM +0300, Mika Kuoppala wrote: > > crtc is holding a reference to a cursor bo and it needs > > to be released when crtc is destroyed so that we don't leak > > the cursor bo. > > > > v2: Enhance set and move cursor so that disabled > > cursor is handled correctly (Ville Syrj?l?) > > > > Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com> > > Oh, nice catch! > > Could we somehow test this in an igt? I'm thinking of the following > sequence: > - Check how many objects there are in debugfs (maybe that needs a slightly > saner interface than what we currently have in i915_gem_objects). > - Setup a mode and provoke the leak (we could augment the tests with > sprites and similar stuff). > - Check whether the object count dropped back to the old value or not. If > not, fail the test. It's a leak upon module unload, so presumably you want to use kmemleak instead. -Chris -- Chris Wilson, Intel Open Source Technology Centre
