On Thu, Apr 04, 2013 at 06:32:34PM +0300, Mika Kuoppala wrote: > Only execbuffer needs all the parameters. Cleanup everything > else behind macro. > > v2: _i915_add_request as function name (Chris Wilson) > Wouldn't the convention be __i915_add_request? > Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com> In terms of cleanups however, I would like to put the return parameter (seqno) last. A later patch in the series makes that even more desirable IMO. I wouldn't bother with this patch, personally. Anyway, because I can't find anything functionally incorrect, an unenthusiastic: Reviewed-by: Ben Widawsky <ben at bwidawsk.net> If you fix up the argument list ordering, a somewhat enthusiastic: Reviewed-by: Ben Widawsky <ben at bwidawsk.net> [snip] -- Ben Widawsky, Intel Open Source Technology Center
