On Tue, Apr 16, 2013 at 10:22 PM, Egbert Eich <eich at freedesktop.org> wrote: > On Tue, Apr 16, 2013 at 08:07:09PM +0200, Daniel Vetter wrote: >> On Tue, Apr 16, 2013 at 01:36:58PM +0200, Egbert Eich wrote: >> > We disable hoptplug detection when we encounter a hotplug event >> > storm. Still hotplug detection is required on some outputs (like >> > Display Port). The interrupt storm may be only temporary (on certain >> > Dell Laptops for instance it happens at certain charging states of >> > the system). Thus we enable it after a certain grace period (2 minutes). >> > Should the interrupt storm persist it will be detected immediately >> > and it will be disabled again. >> > >> > v2: Reordered drm_i915_private: moved hotplug_reenable_timer to hpd state tracker. >> > v3: Clarified loop start value, >> > Removed superfluous test for Ivybridge and Haswell, >> > Restructured loop to avoid deep nesting (all suggested by Ville Syrj?l?) >> > v4: Fixed two bugs pointed out by Jani Nikula. >> > >> > Signed-off-by: Egbert Eich <eich at suse.de> >> > Reviewed-by: Jani Nikula <jani.nikula at intel.com> >> >> I've queued up patches 1-5 of this series, thanks a lot for doing all >> this. Wrt bikesheds: checkpatch seemed a bit unhappy about some of them, >> but I've decided that I want this more for 3.10 than care about checkpatch >> ;-) > > I've run checkpatch on every patch - here it only complains about lines longer > than 80 characters. > Now - if you can prove that my file introduced lines with more than 80 characters > to a file that had no such lines already we can talk about fixing this ;p Yeah, the nesting levels in i915_irq.c are already pretty offensive, hence why I didn't complain louder than with a little comment after merging ;-) But maybe someone reading this is a bit bored and looks for an easy refactor patch ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
