[PATCH v3 6/7] drm/i915: Add bit field to record which pins have received HPD events (v2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 11, 2013 at 04:21:54PM +0300, Jani Nikula wrote:
> >  		}
> > +		if (hpd_event_bits & (1 << intel_encoder->hpd_pin)) {
> > +			DRM_DEBUG_KMS("Connector %s (pin %i) received hotplug event.\n",
> > +				      drm_get_connector_name(connector), intel_encoder->hpd_pin);
> > +		}
> 
> I fear this may end up being a bit excessive debug printing.
> 

In a storm condition this is definitely true.
I still would like to keep this code in for debugging as I have 
some more ideas I would like to implement and test - however I
will wrap this code with #if 0 .. #endif so it can be enabled
easily.
Eventually I will remove it entirely.
Would this be ok with you?

Cheers,
	Egbert.


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux