On Wed, 10 Apr 2013 20:45:11 +0100 Chris Wilson <chris at chris-wilson.co.uk> wrote: > + ring_freq = (gpu_freq * 5 + 3) / 4; > + ring_freq = max(max_ring_freq, ring_freq); Should this be min(max_ring_freq, ring_freq)? Otherwise it seems like every ia_freq will correspond to the highest ring freq. Also, where are you setting ia_freq in the HSW case? Looks like it'll be 0? I guess that means we just need the gpu and ring freq correlation on HSW, but that reinforces Daniel's point that a separate function would probably be clearer. Or you could update the changelog with "scale the ring frequency directly with the GPU frequency" or something. -- Jesse Barnes, Intel Open Source Technology Center
