On Tue, Apr 02, 2013 at 11:26:06PM +0200, Daniel Vetter wrote: > On Tue, Apr 2, 2013 at 11:20 PM, Jesse Barnes <jbarnes at virtuousgeek.org>wrote: > > > On Thu, 28 Mar 2013 10:42:03 +0100 > > Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > > > > > With the exception of hsw, which has dedicated DP clocks which run at > > > the fixed frequency already, and vlv, which doesn't have optmized > > > pre-defined dp clock parameters (yet). > > > > > > > Nice. I think we should do this for common HDMI modes too. We have > > some extra clock manipulation regs we can use to tune things, so having > > fixed dividers for 720p and 1080p along with the tuning params should > > give us better behavior than what we have today. > > > Imo we still have a few lower-hanging fruit before we need to start doing > clock fine-tuning in hdmi-land: Atm we don't really bother with supporting > the 1001/1000 modified clocks in the CEA spec at all ... Once we have the > support code for that, adding fine-tuned clocks for those modes starts to > make sense, so that we really hit them spot-on. I've dropped this patch here again for now, since the previous patch is horribly broken: It completely missed to transform the ironlake dpll functions over to use pipe_config->dpll instead of the intel_clock_t computed. Thanks to Paulo for dissecting this embarassement. /me hides in shame Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
