On Tue, Apr 02, 2013 at 02:14:23PM -0700, Jesse Barnes wrote: > This one's hard to review since you mixed in a drm_crtc->intel_crtc > function arg change. > > I'd rather have that split out, but it looks ok. Yeah, I've fumbled this one a bit, but decided to punt on the split-up. Generally I'm always a bit unsure when exactly we should do rote refactoring like this: We have a similar conversion going on from drm_encoder->intel_encoder, also with the switch away from the drm crtc helper vtables to our own. Usually I don't switch code I don't yet touch (Paulo complained about that, too) since such massive sed jobs simply make patch rebasing complete hell. Both for me, but also for anyone else with an in-flight patch series touching the same area. But once in a while I get fed up and convert a few more things while touching them, leading the slightly ugly patches ... > Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org> Thanks for the review, entire series is merged for -next. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
