On Thu, Mar 28, 2013 at 05:45:06PM +0200, Ville Syrj?l? wrote: > On Thu, Mar 28, 2013 at 04:38:08PM +0100, Daniel Vetter wrote: > > Ville pointed out that my assumption that no unsupported pixel format > > can get past the pipe config computation stage to the platform > > update_plane callbacks is wrong. The reason is that this function > > still checks the old fb->depth value instead of the new pixel_format. > > > > While checking with all the other places that use this I've noticed > > that intel_framebuffer_init already has all the platform checks we > > need, so replace those checks with a WARN_ON. > > > > Since fb->depth isn't set for YUV pixel formats and since we already > > can't create an fb with an rgb layout not support on the running > > platform I /think/ this patch doesn't fix any bug. > > > > But it surely looks better! > > > > v2: BGR formats are also only gen4+, so add the corresponding WARN_ON, > > too (Ville). > > > > Cc: Ville Syrj?l? <ville.syrjala at linux.intel.com> > > Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch> > > Reviewed-by: Ville Syrj?l? <ville.syrjala at linux.intel.com> Both patches merged to dinq, thanks for the review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
